[wasm] Gate atomic write option usages behind platform check #5198
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
I've forgotten to change swift-corelibs-foundation. Thank you! |
parkera
reviewed
Mar 31, 2025
|
Yes, there are still certain amounts of existing code using that running on the platform. |
|
@swift-ci test Windows |
|
I have the same general concern here, that we're simply suppressing the error instead of doing something to tell the developer it won't work. I wonder if it would be better to make the whole method unavailable. |
`Data.WritingOptions.atomic` is now unavailable on WASI: swiftlang/swift-foundation#992
kateinoigakukun
force-pushed
the
pr-6283b78c604f8c9f51b3856f310d11f04fc92b3b
branch
from
ac84026 to
37f6d25
Compare
|
@parkera Good point. I think it makes sense to make them unavailable on WASI. |
|
@swift-ci test |
|
@swift-ci test Windows |
parkera
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data.WritingOptions.atomicis now unavailable on WASI swiftlang/swift-foundation#992, so we need to gate them behind platform checks