[wasm] Use pthread API for NSLock for wasip1-threads target #5293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SWIFT_CORELIBS_FOUNDATION_HAS_THREADS` is not defined for all WASI targets now but we do have pthread support for wasip1-threads target. `_runtime(_multithreaded)` check is more appropriate here to detect multithreaded runtime support. We can remove `SWIFT_CORELIBS_FOUNDATION_HAS_THREADS` definition later.
Member
Author
|
@swift-ci test |
Recent wasi-libc versions include pthreads support for wasip1-threads target and a stub implementation for wasip1 target.
kateinoigakukun
force-pushed
the
pr-f8de02d185c8183f6a63950b75731c051be41c42
branch
from
a46f221 to
30ec87a
Compare
Member
Author
|
@swift-ci test |
1 similar comment
Member
Author
|
@swift-ci test |
compnerd
reviewed
Dec 12, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Is SWIFT_CORELIBS_FOUNDATION_HAS_THREADS used at all anymore? I wonder if we should drop the flag now.
Member
Author
|
@compnerd Yes, that change is already on my working branch and will be the next PR after this PR get merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIFT_CORELIBS_FOUNDATION_HAS_THREADSis not defined for all WASI targets now but we do have pthread support for wasip1-threads target._runtime(_multithreaded)check is more appropriate here to detect multithreaded runtime support. We can removeSWIFT_CORELIBS_FOUNDATION_HAS_THREADSdefinition later.