Add missing Sendable conformances to DispatchPredicate, DispatchQoS, and DispatchTimeoutResult.
#859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test |
1 similar comment
Member
Author
|
@swift-ci please test |
10 tasks
xedin
reviewed
Feb 24, 2025
hborla
force-pushed
the
dispatchqos-sendable
branch
2 times, most recently
from
8f3874c to
a2ddc62
Compare
`DispatchQoS`, and `DispatchTimeoutResult`.
hborla
force-pushed
the
dispatchqos-sendable
branch
from
a2ddc62 to
e36dbda
Compare
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test Windows |
Member
Author
|
Looks like the Windows failure is in an unrelated test in swift-format |
Member
Author
|
swiftlang/swift#79543 @swift-ci please test Windows |
compnerd
approved these changes
Feb 25, 2025
akmorrison
approved these changes
Feb 26, 2025
Contributor
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types are all trivially
Sendable.The lack of conformance has caused source compatibility failures in cross platform libraries, as shown in swiftlang/swift-source-compat-suite#964 (comment).