-
Notifications
You must be signed in to change notification settings - Fork 202
[Dependency Scanning] Remove obsolete placeholder module concept #1917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependency Scanning] Remove obsolete placeholder module concept #1917
Conversation
@swift-ci test |
Great to see these will be removed soon! |
This was used a long time ago for a design of a scanner which could rely on the client to specify that some modules *will be* present at a given location but are not yet during the scan. We have long ago determined that the scanner must have all modules available to it at the time of scan for soundness. This code has been stale for a couple of years and it is time to simplify things a bit by deleting it.
9fc2668
to
f924784
Compare
@swift-ci test |
@swift-ci test Windows platform |
@swift-ci test Windows platform |
1 similar comment
@swift-ci test Windows platform |
@swift-ci test |
@@ -788,12 +785,12 @@ public struct Driver { | |||
integratedDriver: integratedDriver, | |||
compilerIntegratedTooling: false, | |||
compilerExecutableDir: compilerExecutableDir, | |||
externalTargetModuleDetailsMap: externalTargetModuleDetailsMap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing a deprecated public init doesn't quite make sense? If you change it, you might as well just delete it.
Or we can just silently ignore the field rather than deleting the parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is changing the underlying init
that the deprecated public init itself is calling, rather than the signature of the deprecated public init. So in effect we are silently ignoring the field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my bad. The way GitHub website fold the code makes it looks like a change to the function signature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -788,12 +785,12 @@ public struct Driver { | |||
integratedDriver: integratedDriver, | |||
compilerIntegratedTooling: false, | |||
compilerExecutableDir: compilerExecutableDir, | |||
externalTargetModuleDetailsMap: externalTargetModuleDetailsMap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my bad. The way GitHub website fold the code makes it looks like a change to the function signature.
This was used a long time ago for a design of a scanner which could rely on the client to specify that some modules will be present at a given location but are not yet during the scan. We have long ago determined that the scanner must have all modules available to it at the time of scan for soundness. This code has been stale for a couple of years and it is time to simplify things a bit by deleting it.