Skip to content

[Dependency Scanning] Remove obsolete placeholder module concept #1917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jun 4, 2025

This was used a long time ago for a design of a scanner which could rely on the client to specify that some modules will be present at a given location but are not yet during the scan. We have long ago determined that the scanner must have all modules available to it at the time of scan for soundness. This code has been stale for a couple of years and it is time to simplify things a bit by deleting it.

@artemcm
Copy link
Contributor Author

artemcm commented Jun 4, 2025

@swift-ci test

@nkcsgexi
Copy link
Contributor

nkcsgexi commented Jun 4, 2025

Great to see these will be removed soon!

This was used a long time ago for a design of a scanner which could rely on the client to specify that some modules *will be* present at a given location but are not yet during the scan. We have long ago determined that the scanner must have all modules available to it at the time of scan for soundness. This code has been stale for a couple of years and it is time to simplify things a bit by deleting it.
@artemcm artemcm force-pushed the RemovePlaceholdersInDepScanner branch from 9fc2668 to f924784 Compare June 5, 2025 18:11
@artemcm
Copy link
Contributor Author

artemcm commented Jun 5, 2025

@swift-ci test

@artemcm
Copy link
Contributor Author

artemcm commented Jun 5, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 6, 2025

@swift-ci test Windows platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Jun 6, 2025

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Jun 11, 2025

@swift-ci test

@artemcm artemcm requested review from cachemeifyoucan and owenv June 11, 2025 16:25
@@ -788,12 +785,12 @@ public struct Driver {
integratedDriver: integratedDriver,
compilerIntegratedTooling: false,
compilerExecutableDir: compilerExecutableDir,
externalTargetModuleDetailsMap: externalTargetModuleDetailsMap,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing a deprecated public init doesn't quite make sense? If you change it, you might as well just delete it.

Or we can just silently ignore the field rather than deleting the parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changing the underlying init that the deprecated public init itself is calling, rather than the signature of the deprecated public init. So in effect we are silently ignoring the field.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad. The way GitHub website fold the code makes it looks like a change to the function signature.

Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -788,12 +785,12 @@ public struct Driver {
integratedDriver: integratedDriver,
compilerIntegratedTooling: false,
compilerExecutableDir: compilerExecutableDir,
externalTargetModuleDetailsMap: externalTargetModuleDetailsMap,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad. The way GitHub website fold the code makes it looks like a change to the function signature.

@artemcm artemcm merged commit 8594e08 into swiftlang:main Jun 11, 2025
3 checks passed
@artemcm artemcm deleted the RemovePlaceholdersInDepScanner branch June 11, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants