Introduce trailingCommasInMultilineLists configuration
#1044
+943
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTOzzi
requested review from
allevato,
bnbarham,
hamishknight and
rintaro
as code owners
TTOzzi
force-pushed
the
trailingCommasInLists
branch
from
f712fd2 to
c5fb5d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #946
Added a configuration to support the use of trailing commas extended by SE-0439.
This configuration supports three values:
always: always insert trailing commas in multiline listsnever: always remove trailing commasignore: preserve existing commas as-isThe default value is
ignore.The main concern was how to integrate this with the existing
multiElementCollectionTrailingCommasconfiguration.For now,
trailingCommasInMultilineListstakes higher precedence, but to minimize its impact onmultiElementCollectionTrailingCommas, it is implemented so that when set to the default valueignore, the behavior ofmultiElementCollectionTrailingCommasis preserved.I’d appreciate any suggestions or feedback you may have.