Restore selective nil path behavior for bridged NSURLs #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compatibility issue that occurs when a
URLsuch asscheme://?queryis bridged to anNSURL.NSURLoriginally expected.pathto returnnilfor this string, butURLand RFC 3986 say that the path always exists and is the empty string in this case.URLwould then store an empty path range instead when bridging toNSURL, causing this discrepancy.This PR fixes the issue during bridging by only storing the path range if
NSURLwould think there's a path, i.e. in the case where 1) the path is not empty, or 2) the path is empty, but we have a non-empty authority component.