Disallow the @Test attribute on operator declarations.
#1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR prevents `@Test` from being applied to an operator declaration such as: ```swift @test(arguments: ...) static func +(lhs: A, rhs: B) { ... } ``` Now, the following error will be emitted by the compiler: > 🛑 Attribute 'Test' cannot be applied to an operator Previously, applying `@Test` to an operator produced undefined/unstable effects. Resolves #1204.
grynspan
requested review from
briancroom,
stmontgomery and
suzannaratcliff
as code owners
grynspan
added
bug
Contributor
Author
|
@swift-ci test |
stmontgomery
approved these changes
Jul 7, 2025
grynspan
added a commit
that referenced
this pull request
Jul 7, 2025
This PR prevents `@Test` from being applied to an operator declaration such as: ```swift @test(arguments: ...) static func +(lhs: A, rhs: B) { ... } ``` Now, the following error will be emitted by the compiler: > 🛑 Attribute 'Test' cannot be applied to an operator Previously, applying `@Test` to an operator produced undefined/unstable effects. Resolves #1204. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Jul 8, 2025
- **Explanation**: Block `@Test` on operator declarations, which doesn't work correctly and was never supported. - **Scope**: Attempting to declare `@Test func +()`. - **Issues**: #1204 - **Original PRs**: #1205 - **Risk**: Low (this was never supported) - **Testing**: New test case added. - **Reviewers**: @stmontgomery @briancroom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents
@Testfrom being applied to an operator declaration such as:Now, the following error will be emitted by the compiler:
Previously, applying
@Testto an operator produced undefined/unstable effects.Resolves #1204.
Checklist: