Handle image types derived from the base types. #1399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Apple platforms, you can declare file types (uniform type identifiers, or "UTTypes" for short) that conform to existing types. That means a developer could conceivably say "save this image as .florb" where `.florb` represents a type that conforms to, but is not identical to, `.jpeg`. This PR ensures that if a developer passes such a type, we handle it by passing the supported base type to Image I/O. And, if the developer passes some image format that is unsupported by Image I/O, we can throw an error with a more specific diagnostic than just "it failed."
grynspan
requested review from
briancroom,
jerryjrchen and
stmontgomery
as code owners
grynspan
added
enhancement
jerryjrchen
approved these changes
Nov 7, 2025
Sources/Overlays/_Testing_CoreGraphics/Attachments/AttachableAsCGImage.swift
Show resolved
Hide resolved
Sources/Overlays/_Testing_CoreGraphics/Attachments/AttachableAsCGImage.swift
Show resolved
Hide resolved
stmontgomery
approved these changes
Nov 7, 2025
|
I think you need to rebase the PR to pick up the GItHub Actions fixes for Amazon Linux 2 + Android. It appears re-running a failing job will still use the commit of the swiftlang/github-workflows repository at the time the PR was last pushed, rather than when the job was last run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Apple platforms, you can declare file types (uniform type identifiers, or "UTTypes" for short) that conform to existing types. That means a developer could conceivably say "save this image as .florb" where
.florbrepresents a type that conforms to, but is not identical to,.jpeg.This PR ensures that if a developer passes such a type, we handle it by passing the supported base type to Image I/O. And, if the developer passes some image format that is unsupported by Image I/O, we can throw an error with a more specific diagnostic than just "it failed."
Checklist: