Skip to content

[6.2][cxx-interop] Fix a rare compilation error in reverse interop header #80631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

Xazax-hun
Copy link
Contributor

@Xazax-hun Xazax-hun commented Apr 8, 2025

Explanation: Fix a compilation error in the generated reverse interop header when a nested foreign type is used in a generic context and it is reexposed to C++.
Issue: rdar://148597079
Risk: Low, the fix is fairly targeted to the affected scenario.
Testing: Added tests to test suite
Original PR: #80598
Reviewer: @egorzhdan

…ader

Explanation: Fix a compilation error in the generated reverse interop
header when a nested foreign type is used in a generic context and it is
reexposed to C++.
Issue: rdar://148597079
Risk: Low, the fix is fairly targeted to the affected scenario.
Testing: Added tests to test suite
Reviewer: @egorzhdan
@Xazax-hun Xazax-hun added c++ interop Feature: Interoperability with C++ 🍒 release cherry pick Flag: Release branch cherry picks labels Apr 8, 2025
@Xazax-hun Xazax-hun requested a review from egorzhdan April 8, 2025 10:35
@Xazax-hun Xazax-hun requested a review from a team as a code owner April 8, 2025 10:35
@Xazax-hun
Copy link
Contributor Author

@swift-ci please test

@Xazax-hun
Copy link
Contributor Author

@swift-ci please test macos

@Xazax-hun Xazax-hun merged commit ae55f3e into release/6.2 Apr 14, 2025
5 checks passed
@Xazax-hun Xazax-hun deleted the gaborh/nested-foreign-type-metadata-on-6.2 branch April 14, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++ 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants