[stdlib] fix an extraneous symbol exported by MutableSpan #81816
+1
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain macOS platform |
|
@swift-ci please test |
Azoy
approved these changes
May 28, 2025
jmschonfeld
reviewed
May 28, 2025
| @@ -55,8 +55,7 @@ extension MutableSpan: @unchecked Sendable where Element: Sendable {} | |||
| extension MutableSpan where Element: ~Copyable { | |||
|
|
|||
| @unsafe | |||
| @_unsafeNonescapableResult | |||
There was a problem hiding this comment.
Just confirming: the removal of @_unsafeNonescapableResult was intentional?
There was a problem hiding this comment.
Yes it's intentional: we don't need it given that a @lifetime annotation is in place. @_unsafeNonescapableResult predated the existence of the @lifetime annotation.
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #79650, one of the initializers was not marked
@_alwaysEmitIntoClient, by mistake. This fixes the mistake, and adjusts the list of ABI symbols accordingly.