[6.2][Runtime] Add ptrauth attribute to TargetGlobalActorReference conformance pointer. #81825
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nformance pointer. When the TargetGlobalActorReference conformance is an indirect pointer, the indirect pointer is signed when ptrauth is enabled. rdar://151945202 (cherry picked from commit ea785c1)
|
@swift-ci please test |
nkcsgexi
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #81824 to
release/6.2.Explanation: Adds a necessary ptrauth attribute to GlobalActorReference's indirect pointer type.
Scope: Affects ARM64e processes that take this runtime path.
Issue: rdar://151945202
Risk: Low. This adds a ptrauth attribute to a pointer, which is needed on ARM64e to not crash, and does nothing on all other targets.
Testing: Verified that an example crashes with a ptrauth failure without this fix, and works with it.
Reviewer: @ktoso
When the TargetGlobalActorReference conformance is an indirect pointer, the indirect pointer is signed when ptrauth is enabled.
rdar://151945202