[Concurrency] Fix SendableMetatype conformance failures to behave l…
#82004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
ktoso,
tshortli,
hborla and
slavapestov
as code owners
ktoso
reviewed
Jun 4, 2025
lib/Sema/TypeCheckConcurrency.cpp
Outdated
| /// Sendable. | ||
| static void addSendableFixIt(const GenericTypeParamDecl *genericArgument, | ||
| InFlightDiagnostic &diag) { | ||
| addProtocolFixIt(genericArgument, diag, "Sendable"); |
There was a problem hiding this comment.
minor nit, is it worth doing getProtocolName(KnownProtocolKind::Sendable) ?
DougGregor
approved these changes
Jun 4, 2025
| @@ -5943,6 +5943,8 @@ ERROR(concurrent_value_inherit,none, | |||
| (bool, DeclName)) | |||
| ERROR(non_sendable_type,none, | |||
| "type %0 does not conform to the 'Sendable' protocol", (Type)) | |||
| ERROR(non_sendable_metatype_type,none, | |||
There was a problem hiding this comment.
Can you put this diagnostic in the new SendableMetatypes group?
ktoso
approved these changes
Jun 4, 2025
|
@swift-ci please test |
…ike `Sendable` ones No warnings with minimal checking, warnings with `strict-concurrency=complete` and if declaration is `@preconcurrency` until next major swift version. Resolves: rdar://151911135 Resolves: swiftlang#81739
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
|
@swift-ci please clean test Linux platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ike
SendableonesNo warnings with minimal checking, warnings with
strict-concurrency=completeand if declaration is@preconcurrencyuntil next major swift version.Resolves: rdar://151911135
Resolves: #81739