Skip to content

[Concurrency] Downgrade isolated conformances to SendableMetatype protocols to a warning for implicitly @preconcurrency protocols. #83136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hborla
Copy link
Member

@hborla hborla commented Jul 17, 2025

This error was accidentally not downgraded for implicitly @preconcurrency protocols, including all protocols imported from Objective-C.

Resolves: rdar://155821329

protocols to a warning for implicitly `@preconcurrency` protocols.
@hborla
Copy link
Member Author

hborla commented Jul 17, 2025

@swift-ci please smoke test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It seems like we should have a combined check that does moduleImportForPreconcurrency and decl->preconcurrency(), but that doesn't need to be this PR.

@hborla hborla merged commit 9214b0c into swiftlang:main Jul 17, 2025
3 checks passed
@hborla hborla deleted the invalid-isolated-conformance-downgrade branch July 17, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants