Skip to content

Create VSIXs with -dev suffix for PR builds #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Create VSIXs with -dev suffix for PR builds #1691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ jobs:
. .github/workflows/scripts/setup-linux.sh
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
npm ci
npm run package
npm run preview-package
npm run dev-package
npm run preview-package -- dev
for file in *.vsix; do
name="$(basename "$file" .vsix)-${{github.run_number}}.vsix"
echo "Created bundle $name"
Expand Down
5 changes: 4 additions & 1 deletion scripts/preview_package.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ main(async () => {
// Increment the minor version and set the patch version to today's date
const minor = version.minor + 1;
const patch = formatDate(new Date());
const previewVersion = `${version.major}.${minor}.${patch}`;
let previewVersion = `${version.major}.${minor}.${patch}`;
if (process.argv.includes("dev")) {
previewVersion = `${previewVersion}-dev`;
}
// Make sure that the new minor version is odd
if (minor % 2 !== 1) {
throw new Error(
Expand Down
Loading