Improve handling misconfigured Swift toolchain #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes a few improvements around handling a misconfigured toolchain. - Register the Select Toolchain command before prompting the user with an error dialog during extension activation. There was a button in the dialog to Select Toolchain, but the command wasn't registered yet so they'd get an error. - Prompt the user with this same error dialog if they have a misconfigured toolchain for a specific folder. Typically this happens when the user adds a folder to an existing workspace, and that folder has a misconfigured toolchain in the `.vscode/settings.json` file.
plemarquand
requested review from
adam-fowler,
0xTim and
award999
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch makes a few improvements around handling a misconfigured toolchain.
.vscode/settings.jsonfile.Tasks