Feat/toml config support#70
Closed
T3Marius wants to merge 2 commits into
Closed
Conversation
…ction - Replace custom TomlModelHelper class with Toml.FromModel() - Remove 117 lines of manual reflection-based TOML conversion - Simplify InitializeTomlWithModel to use native Tomlyn serialization - Clean up unused imports (System.Diagnostics.CodeAnalysis, System.Reflection, Tomlyn.Model) - Improve code maintainability and reliability
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored TOML configuration serialization to use Tomlyn's built-in
FromModel()method instead of custom reflection-based conversion, simplifying the codebase and improving maintainability.Type of Change
Related Issues
N/A
Changes Made
Detailed Changes
TomlModelHelperstatic class (117 lines of custom reflection code)InitializeTomlWithModelto use Tomlyn's nativeToml.FromModel()serializationSystem.Diagnostics.CodeAnalysis,System.Reflection,Tomlyn.Model)Testing
Test Environment
Test Cases
Breaking Changes
None - This is a pure refactoring with no API or functionality changes.
Performance Impact
Details: Using Tomlyn's optimized built-in serialization instead of custom reflection should provide better performance and reliability.
Checklist
Additional Notes
This refactoring improves code maintainability by leveraging Tomlyn's tested and optimized serialization capabilities instead of maintaining custom reflection-based conversion logic. The approach now matches the pattern used for JSON configuration, providing consistency across the codebase.