-
Notifications
You must be signed in to change notification settings - Fork 21
chore(docs): add templates for multiple HTTP error types #6764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 75e0553 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…thub.com/swisspost/design-system into 5847-add-additional-error-page-templates
| `} | ||
| </div> | ||
| </div> | ||
| <div class="col error-container--image ${extraClass}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the design, you can see that the image is not within a column but rather flush with the right of the screen (e.g. the 401 error, you can see the vault touched the end of the screen). You can use section alignment to do that: https://swisspost-design-system-next.netlify.app/?path=/docs/49b036fc-5c54-46da-b6d1-081f0c731b05--docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Margins and paddings are incorrect in a few places.
For instance, this one should have more padding around the image on mobile:

401: The vault on mobile takes too much space
All error pages: Margins are incorrect in mobile (title should have a margin top)
Could you go through all of the error pages again and check that all margins and paddings are consistent with the design.
packages/documentation/src/stories/templates/error-page/error-page.stories.ts
Show resolved
Hide resolved
|



📄 Description
Cette demande de modification ajoute des modèles configurables pour plusieurs pages d'erreur HTTP (400, 401, 403, 404, 451, 500, 503, 504) avec des illustrations dédiées, des textes prédéfinis et une mise en page entièrement réactive basée sur des palettes, des sections, des conteneurs et une grille.
🚀 Demo
If applicable, please add a screenshot or video to illustrate the changes.
🔮 Design review
📝 Checklist