Skip to content

Conversation

@hugomslv
Copy link
Contributor

📄 Description

Cette demande de modification ajoute des modèles configurables pour plusieurs pages d'erreur HTTP (400, 401, 403, 404, 451, 500, 503, 504) avec des illustrations dédiées, des textes prédéfinis et une mise en page entièrement réactive basée sur des palettes, des sections, des conteneurs et une grille.

🚀 Demo

If applicable, please add a screenshot or video to illustrate the changes.


🔮 Design review

  • Design review done
  • No design review needed

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@hugomslv hugomslv requested review from a team as code owners November 28, 2025 13:20
@hugomslv hugomslv requested a review from leagrdv November 28, 2025 13:20
@hugomslv hugomslv linked an issue Nov 28, 2025 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025

🦋 Changeset detected

Latest commit: 75e0553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@swisspost/design-system-documentation Minor
@swisspost/design-system-styles Minor
@swisspost/design-system-components-angular-workspace Minor
@swisspost/design-system-components Minor
@swisspost/internet-header Minor
@swisspost/design-system-nextjs-integration Minor
@swisspost/design-system-styles-primeng-workspace Minor
@swisspost/design-system-styles-primeng Minor
@swisspost/design-system-components-react Minor
@swisspost/design-system-components-angular Minor
@swisspost/design-system-changelog-github Minor
@swisspost/design-system-eslint Minor
@swisspost/design-system-icons Minor
@swisspost/design-system-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 28, 2025

Related Previews

`}
</div>
</div>
<div class="col error-container--image ${extraClass}">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the design, you can see that the image is not within a column but rather flush with the right of the screen (e.g. the 401 error, you can see the vault touched the end of the screen). You can use section alignment to do that: https://swisspost-design-system-next.netlify.app/?path=/docs/49b036fc-5c54-46da-b6d1-081f0c731b05--docs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Margins and paddings are incorrect in a few places.
For instance, this one should have more padding around the image on mobile:
Capture d'écran 2025-12-01 090002

401: The vault on mobile takes too much space
All error pages: Margins are incorrect in mobile (title should have a margin top)

Could you go through all of the error pages again and check that all margins and paddings are consistent with the design.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add additional error page templates

4 participants