feat(docs, styles): create html/css Divider component #6783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d ready to test tokens
…s in `_index.scss`, added text for docs
4 tasks
🦋 Changeset detectedLatest commit: a9a923e The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
bucknatt
requested review from
myrta2302
and removed request for
oliverschuerch
myrta2302
reviewed
Dec 5, 2025
packages/documentation/src/stories/components/divider/divider.docs.mdx
Outdated
Show resolved
Hide resolved
myrta2302
reviewed
Dec 5, 2025
packages/documentation/src/stories/components/divider/divider.stories.ts
Outdated
Show resolved
Hide resolved
myrta2302
reviewed
Dec 5, 2025
packages/documentation/src/stories/components/divider/divider.docs.mdx
Outdated
Show resolved
Hide resolved
myrta2302
reviewed
Dec 5, 2025
packages/documentation/src/stories/foundations/typography/typography.docs.mdx
Show resolved
Hide resolved
myrta2302
reviewed
Dec 5, 2025
packages/documentation/src/stories/components/divider/divider.docs.mdx
Outdated
Show resolved
Hide resolved
myrta2302
requested changes
Dec 5, 2025
Contributor
myrta2302
left a comment
myrta2302
left a comment
There was a problem hiding this comment.
I think this should be a "minor" bump, since we’re adding something new.
…mpo on docs, updated link to figma
Implemented a `Divider` component with styles using tokens and updated documentation.
|
oliverschuerch
requested changes
Dec 5, 2025
| '@swisspost/design-system-styles': minor | ||
| --- | ||
|
|
||
| Implemented a `Divider` html/css component using tokens for styles. Divider documentation is also added to /Foundations/Typography page. |
Contributor
There was a problem hiding this comment.
Suggested change
| Implemented a `Divider` html/css component using tokens for styles. Divider documentation is also added to /Foundations/Typography page. | |
| Implemented a `Divider` html/css component using tokens for styles. Divider documentation is also added to /Components/Divider page. |
Comment on lines
+19
to
+22
| <Canvas sourceState="shown" of={DividerStories.Default} /> | ||
| <div className="hide-col-default"> | ||
| <Controls of={DividerStories.Default} /> | ||
| </div> |
Contributor
There was a problem hiding this comment.
We should mention here, that one can simply use our spacing utilities to change the default margin above/below.
e.g.
A dividers top and bottom default margin can be overridden by using our spacing utilities.
Comment on lines
+26
to
+28
| ## Usage | ||
|
|
||
| Dividers are often used within forms. |
Contributor
There was a problem hiding this comment.
I would remove that, as it does not provide any value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
margin-topand themargin-bottomclasses to change the spacing as following: 4px, 8px (default, so no classes), 16px, 24px, 32px, 40px). Users can define them separately for top and bottom./foundations/typographypage.🚀 Demo
🔮 Design review
📝 Checklist