NEVER MERGE THIS PR! This PR is just here for handy comparison of websockets and [webrtc] main branches!
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for WebRTC
chore: use env file.
remove outdated reference to Astro and unused Astro files
Update README.md
paulpv
force-pushed
the
main
branch
4 times, most recently
from
8da9f4e to
e5ab62f
Compare
dangerousApiKey input gain focus. code comments about how dangerousApiKey is used.
paulpv
force-pushed
the
main
branch
8 times, most recently
from
4fd97d8 to
35fa543
Compare
Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 4 to 5. - [Release notes](https://github.com/actions/configure-pages/releases) - [Commits](actions/configure-pages@v4...v5) --- updated-dependencies: - dependency-name: actions/configure-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https://github.com/eslint/eslint) from 9.20.0 to 9.20.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.20.0...v9.20.1) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bump eslint from 9.20.0 to 9.20.1
…onfigure-pages-5
Bumps [globals](https://github.com/sindresorhus/globals) from 15.14.0 to 16.0.0. - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v15.14.0...v16.0.0) --- updated-dependencies: - dependency-name: globals dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@tailwindcss/vite](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/@tailwindcss-vite) from 4.0.6 to 4.0.8. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.0.8/packages/@tailwindcss-vite) --- updated-dependencies: - dependency-name: "@tailwindcss/vite" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint](https://github.com/eslint/eslint) from 9.20.1 to 9.21.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.20.1...v9.21.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/tailwindcss) from 4.0.6 to 4.0.9. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.0.9/packages/tailwindcss) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.1.0 to 6.2.0. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/[email protected]/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents much of 758faf8, but also shows any changes since.
That PR removed 34872 lines of code and added only 4536 (>30k total removed).
I 100% agree that converting the project from WebSocket to WebRTC was the right and best thing!
But, for a test tool, I think that WebSocket should not have been entirely removed.
As a test tool, it would be much more convincing to be able to A/B test WebRTC and WebSocket behavior if you could easily toggle the same app back and forth between them.
Sure, someone can checkout the https://github.com/swooby/openai-realtime-console/tree/websockets branch and run it, but then they have to jump back and forth between two separate branches or clones.
Again, it would be much more convincing to A/B test WebRTC and WebSocket behavior if you could easily toggle the same app back and forth between them.
The reason for this PR is to track the WebSocket->WebRTC changes because I naively hope to one day restore WebSocket back into the app.
NOTE that there is also https://github.com/transitive-bullshit/openai-realtime-api (an improve and TypeScripted version of https://github.com/openai/openai-realtime-api-beta), which itself contains a snapshot of this [fork's original] repo at https://github.com/transitive-bullshit/openai-realtime-api/tree/main/examples/openai-realtime-console to prove that its
openai-realtime-apilibrary works with theopenai-realtime-consoleas a drop-in replacement for@openai/realtime-api-beta.I created transitive-bullshit/openai-realtime-api#12 to consider adding WebRTC to that
openai-realtime-apilibrary, which it looks like someone else did a version of at longseespaceadd support for WebRTCClient.So, in reality any efforts/progress that I make to get
openai-realtime-consoleto toggle between WebRTC and WebSocket will probably be on a fork of https://github.com/transitive-bullshit/openai-realtime-api/tree/main/examples/openai-realtime-console.That would make this PR literally just here for reference reasons only.