Fix failing GH pages deploy workflow

[hirasso]

Description

Closes #214

Fix the failing deploy.yml workflow. We deploy to netlify so that file was a leftover anyways

Drive-By

• Update browserslist

Checks

• The PR is submitted to the main branch
• The code was linted before pushing (npm run lint)
• All tests are passing (npm run test)

[netlify]

✅ Deploy Preview for splendorous-kataifi-9ae281 ready!

Name	Link
🔨 Latest commit	4ca46cf
🔍 Latest deploy log	https://app.netlify.com/sites/splendorous-kataifi-9ae281/deploys/67a9ee53e851290008d4d084
😎 Deploy Preview	https://deploy-preview-215--splendorous-kataifi-9ae281.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[daun]

I think we need this action :) Don't we deploy to GitHub Pages?

I wouldn't know how else to trigger a deploy if not via this action.

[daun]

According the the repo settings, we deploy to GitHub Pages. So this action is still required.

[daun]

Looks like we need to deal with the silly forced upload-artifact upgrade :(

[hirasso]

How does the netlify preview work then in this pr? :)

[hirasso]

The repo settings are probably a leftover from jekyll times 👹

[hirasso]

If not sure, lets sleep over it. I'm a bit tired already and might totally be missing something obvious 😄

[daun]

The previews are on Netlify because GitHub Pages can't do branch previews. At least back then it didn't.

What problem are we trying to solve here? I think we need to fix the action, not delete it, right?

[daun]

Looking at the current DNS records, it seems that the main v4 docs are on GitHub Pages, while the old v3 docs are on Netlify. We had tried deploying multiple GitHub Pages sites, but there can only be one site per repo and we didn't want to split the old docs into their own repo. So we had to use Netlify for that.

[hirasso]

Ok sorry, it was definitely too late for my brain yesterday 🥱😵‍💫. And thank you for keeping a cool head! I will revert the deletion and simply update the action later today.

Sorry for the noise!

[daun]

No worries, it's definitely very confusing with v4, v3, and branch previews all doing slightly different things 🤖

[hirasso]

Ready :)

[daun]

Nice! I've renamed to PR 🙃