Skip to content

Change logging level from INFO to DEBUG for some less interesting messages #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change logging level from INFO to DEBUG for some less interesting messages #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a8483
Change logging level from INFO to DEBUG for some less interesting mes…
schroeer Feb 27, 2025
041c21d
Change even more log messages to level debug
schroeer Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions exiftool/exiftool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def executable(self, new_executable: Union[str, Path]) -> None:
# absolute path is returned
self._executable = str(abs_path)

if self._logger: self._logger.info(f"Property 'executable': set to \"{abs_path}\"")
if self._logger: self._logger.debug(f"Property 'executable': set to \"{abs_path}\"")


# ----------------------------------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -428,7 +428,7 @@ def block_size(self, new_block_size: int) -> None:

self._block_size = new_block_size

if self._logger: self._logger.info(f"Property 'block_size': set to \"{new_block_size}\"")
if self._logger: self._logger.debug(f"Property 'block_size': set to \"{new_block_size}\"")


# ----------------------------------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -476,7 +476,7 @@ def common_args(self, new_args: Optional[List[str]]) -> None:
else:
raise TypeError("common_args not a list of strings")

if self._logger: self._logger.info(f"Property 'common_args': set to \"{self._common_args}\"")
if self._logger: self._logger.debug(f"Property 'common_args': set to \"{self._common_args}\"")


# ----------------------------------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -522,7 +522,7 @@ def config_file(self, new_config_file: Optional[Union[str, Path]]) -> None:
else:
self._config_file = str(new_config_file)

if self._logger: self._logger.info(f"Property 'config_file': set to \"{self._config_file}\"")
if self._logger: self._logger.debug(f"Property 'config_file': set to \"{self._config_file}\"")



Expand Down Expand Up @@ -863,7 +863,7 @@ def run(self) -> None:
self.terminate()
raise ExifToolVersionError(f"Error retrieving Exiftool info. Is your Exiftool version ('exiftool -ver') >= required version ('{constants.EXIFTOOL_MINIMUM_VERSION}')?")

if self._logger: self._logger.info(f"Method 'run': Exiftool version '{self._ver}' (pid {self._process.pid}) launched with args '{proc_args}'")
if self._logger: self._logger.debug(f"Method 'run': Exiftool version '{self._ver}' (pid {self._process.pid}) launched with args '{proc_args}'")


# currently not needed... if it passes -ver check, the rest is OK
Expand Down Expand Up @@ -933,7 +933,7 @@ def terminate(self, timeout: int = 30, _del: bool = False) -> None:
self._flag_running_false()

# TODO log / return exit status from exiftool?
if self._logger: self._logger.info("Method 'terminate': Exiftool terminated successfully.")
if self._logger: self._logger.debug("Method 'terminate': Exiftool terminated successfully.")



Expand Down Expand Up @@ -1048,7 +1048,7 @@ def execute(self, *params: Union[str, bytes], raw_bytes: bool = False) -> Union[
self._process.stdin.write(cmd_bytes)
self._process.stdin.flush()

if self._logger: self._logger.info("Method 'execute': Command sent = {}".format(cmd_params[:-1])) # logs without the -execute (it would confuse people to include that)
if self._logger: self._logger.debug("Method 'execute': Command sent = {}".format(cmd_params[:-1])) # logs without the -execute (it would confuse people to include that)


# ---------- read output from exiftool process until special sequences reached ----------
Expand Down