Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier and adjust eslint-config #3

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add prettier and adjust eslint-config #3

wants to merge 5 commits into from

Conversation

Souler
Copy link
Member

@Souler Souler commented Dec 3, 2024

We got feedback from some of our candidates that eslint tends to get in the way and the lack of an automatic formatting regarding some of the "opinionated" standards of the indistry make it hard to keep a consistent codestyle.

This PR aims at easing that linting-givin-problems part; hopefully making the process easier for anyone willing to take the challeng.

@Souler Souler requested a review from javimbk December 3, 2024 17:05
Copy link

@javimbk javimbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes with this so our candidates can just focus on the important stuff.

Left a nitpick comment on the final new line in package.json and also just for documentation purposes, these are failing but it makes sense since the implementation is not done yet. Just wondering if we should have a "clean" state by disabling and putting a comment to remove the disable when doing the solution.

➜  technical-test-frontend git:(add-prettier) ✗ npm run lint

> [email protected] lint
> eslint . --report-unused-disable-directives --max-warnings 0


/Users/javier/Dev/technical-test-frontend/src/lib/auth/AuthProvider.tsx
  25:11  error  'initialTokens' is assigned a value but never used  @typescript-eslint/no-unused-vars
  25:26  error  'onAuthChange' is assigned a value but never used   @typescript-eslint/no-unused-vars

/Users/javier/Dev/technical-test-frontend/src/lib/auth/useAuth.ts
  14:15  error  'email' is assigned a value but never used     @typescript-eslint/no-unused-vars
  14:22  error  'password' is assigned a value but never used  @typescript-eslint/no-unused-vars

✖ 4 problems (4 errors, 0 warnings)

@@ -45,4 +48,4 @@
"engines": {
"node": ">= 18"
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

Suggested change
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants