[Agent] Dispatch more tool call events #709
Merged
+180
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzwilding
requested review from
chr-hertel,
Nyholm and
OskarStark
as code owners
carsonbot
added
Status: Needs Review
Agent
OskarStark
changed the title
OskarStark
reviewed
Oct 1, 2025
OskarStark
reviewed
Oct 1, 2025
| /** | ||
| * Dispatched after successfully invoking a tool. | ||
| */ | ||
| final readonly class ToolCallSuccess |
There was a problem hiding this comment.
either ToolCallSuccessful or SuccessfulToolCall? Same for the failed one.
WDYT @chr-hertel ?
|
Thanks for tackling this topic, can you please add some docs? |
OskarStark
approved these changes
Oct 1, 2025
chr-hertel
requested changes
Oct 2, 2025
There was a problem hiding this comment.
I think in general this totally makes sense, and I'd only see some fine-tuning here.
- I think it's a bit odd to me having basically two events with the same payload dispatched line after line, referring to
ToolCallArgumentsResolvedandExecuteToolCall- do i miss something here? - I would propose to move to an event-style of naming, and we're half way there
proposed changes:
- drop
ExecuteToolCall - rename
ToolCallSuccesstoToolCallSucceeded
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Reviewed
Status: Needs Work
labels
|
@chr-hertel I renamed the success event and dropped ExecuteToolCall. |
OskarStark
force-pushed
the
feature/680-tool-events
branch
from
a8ec69a to
e17fbd5
Compare
OskarStark
force-pushed
the
feature/680-tool-events
branch
from
e17fbd5 to
36079d2
Compare
|
Thank you @franzwilding, I rebased your PR to get rid of the merge commit 👍 |
|
Nice one @franzwilding - thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR dispatches three new events around tool calling.