[Platform] Support model size variants #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Feature
OskarStark
force-pushed
the
OskarStark/model-size-query-support
branch
from
a6bfc46 to
c401326
Compare
OskarStark
added a commit
that referenced
this pull request
Oct 2, 2025
…on in config (sonnymilton) This PR was squashed before being merged into the main branch. Discussion ---------- [AI Bundle] Add parsing of model names with colon notation in config | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT In #712, support for Ollama models with colon notation was added. However, in the bundle configuration, `parse_url()` incorrectly treated the part before the colon as a URI scheme and discarded it. As a result, model names were normalized to an empty or incomplete string, causing configuration errors. ```php $parsed = parse_url('qwen3:0.6b'); // ['path' => '0.6b', 'scheme' => 'qwen' ] $model = $parsed['path']; // "0.6b" ❌ ``` This change ensures that model names written in colon notation are preserved correctly when parsing bundle configuration, allowing proper usage of Ollama models in Symfony projects. Commits ------- 56714f3 [AI Bundle] Add parsing of model names with colon notation in config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another apporach to #708