-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Promote Invokable Commands #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
659d69b
to
8a8c488
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are invokable commands documented already ?
@@ -49,7 +49,8 @@ | |||
*/ | |||
#[AsCommand( | |||
name: 'app:add-user', | |||
description: 'Creates users and stores them in the database' | |||
description: 'Creates users and stores them in the database', | |||
help: HELP, | |||
)] | |||
final class AddUserCommand extends Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably not extend Command
here if you want to showcase the simplest usage of invokable commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is still not possible without extending from Command
as we're showcasing the initialize and interact methods.
It’s the ListUsersCommand
that showcases the simplest usage
Documentation is in progress symfony/symfony-docs#20932 (working currently on input doc) |
8a8c488
to
125ad1e
Compare
We should merge this PR once the doc is complete/merged |
No description provided.