Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump versions #659

Merged
merged 7 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,14 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.3'
php-version: '8.4'
tools: phpstan,flex
extensions: zip

- name: Install dependencies
uses: ramsey/composer-install@v3
env:
SYMFONY_REQUIRE: 7.0.*
SYMFONY_REQUIRE: ^7

- name: Install PHPUnit dependencies
run: vendor/bin/simple-phpunit --version
Expand All @@ -50,7 +50,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['8.0', '8.1', '8.2', '8.3', '8.4']
php-versions: ['8.1', '8.2', '8.3', '8.4']
fail-fast: false
name: PHP ${{ matrix.php-versions }} Test on ubuntu-latest
steps:
Expand All @@ -73,7 +73,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['8.0', '8.1', '8.2', '8.3', '8.4']
php-versions: ['8.1', '8.2', '8.3', '8.4']
fail-fast: false
name: PHP ${{ matrix.php-versions }} Test dev dependencies on ubuntu-latest
steps:
Expand All @@ -97,15 +97,15 @@ jobs:

phpunit-lowest:
runs-on: ubuntu-latest
name: PHP 8.3 (lowest) Test on ubuntu-latest
name: PHP 8.4 (lowest) Test on ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.3'
php-version: '8.4'
extensions: zip

- name: Install dependencies
Expand All @@ -115,12 +115,12 @@ jobs:

- name: Run tests
env:
SYMFONY_DEPRECATIONS_HELPER: max[total]=9223372036854775807 # PHP_INT_MAX
SYMFONY_DEPRECATIONS_HELPER: "disabled=1"
run: vendor/bin/simple-phpunit

phpunit-windows:
runs-on: windows-latest
name: PHP 8.3 Test on windows-latest
name: PHP 8.4 Test on windows-latest
env:
PANTHER_FIREFOX_BINARY: 'C:\Program Files\Mozilla Firefox\firefox.exe'
SKIP_FIREFOX: 1
Expand All @@ -131,7 +131,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.3'
php-version: '8.4'
extensions: zip

- name: Install dependencies
Expand All @@ -142,15 +142,15 @@ jobs:

phpunit-macos:
runs-on: macos-latest
name: PHP 8.3 Test on macos-latest
name: PHP 8.4 Test on macos-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.3'
php-version: '8.4'
extensions: zip

- name: Install Firefox
Expand All @@ -171,7 +171,7 @@ jobs:
matrix:
php-versions: [ '8.1', '8.2', '8.3', '8.4']
fail-fast: false
name: PHP ${{ matrix.php-versions }} (phpunit 10) Test on ubuntu-latest
name: PHP ${{ matrix.php-versions }} (PHPUnit 11) Test on ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -187,11 +187,11 @@ jobs:
with:
composer-options: "--prefer-dist"

- name: Remove phpunit-bridge dependency (not yet phpunit 10 compliant)
- name: Remove phpunit-bridge dependency (not yet PHPUnit 10+ compliant)
run: composer remove --dev symfony/phpunit-bridge

- name: Install latest phpunit 10
run: composer require --dev --prefer-dist phpunit/phpunit:^10.0
- name: Install latest PHPUnit 11
run: composer require --dev --prefer-dist 'phpunit/phpunit:>=10'

- name: Run tests
run: vendor/bin/phpunit --configuration phpunit.xml.dist.10
20 changes: 10 additions & 10 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@
"ext-dom": "*",
"ext-libxml": "*",
"php-webdriver/webdriver": "^1.8.2",
"symfony/browser-kit": "^5.3 || ^6.0 || ^7.0",
"symfony/dependency-injection": "^5.3 || ^6.0 || ^7.0",
"symfony/browser-kit": "^5.4 || ^6.4 || ^7.0",
"symfony/dependency-injection": "^5.4 || ^6.4 || ^7.0",
"symfony/deprecation-contracts": "^2.4 || ^3",
"symfony/dom-crawler": "^5.3 || ^6.0 || ^7.0",
"symfony/http-client": "^5.3 || ^6.0 || ^7.0",
"symfony/http-kernel": "^5.3 || ^6.0 || ^7.0",
"symfony/process": "^5.3 || ^6.0 || ^7.0"
"symfony/dom-crawler": "^5.4 || ^6.4 || ^7.0",
"symfony/http-client": "^6.4 || ^7.0",
"symfony/http-kernel": "^5.4 || ^6.4 || ^7.0",
"symfony/process": "^5.4 || ^6.4 || ^7.0"
},
"require-dev": {
"symfony/css-selector": "^5.3 || ^6.0 || ^7.0",
"symfony/framework-bundle": "^5.3 || ^6.0 || ^7.0",
"symfony/mime": "^5.3 || ^6.0 || ^7.0",
"symfony/phpunit-bridge": "^5.3 || ^6.0 || ^7.0"
"symfony/css-selector": "^5.4 || ^6.4 || ^7.0",
"symfony/framework-bundle": "^5.4 || ^6.4 || ^7.0",
"symfony/mime": "^5.4 || ^6.4 || ^7.0",
"symfony/phpunit-bridge": "^7.2.0"
},
"minimum-stability": "dev",
"prefer-stable": true,
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml.dist.10
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<php>
<env name="KERNEL_CLASS" value="Symfony\Component\Panther\Tests\DummyKernel"/>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[direct]=0"/>
<server name="SYMFONY_PHPUNIT_VERSION" value="10.0"/>
<server name="SYMFONY_PHPUNIT_VERSION" value=">=10"/>
</php>

<testsuites>
Expand Down
2 changes: 1 addition & 1 deletion tests/ClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ public function testPrefersReducedMotionDisabled(string $browser): void
$client->clickLink('Click me!');
}

public function providePrefersReducedMotion(): iterable
public static function providePrefersReducedMotion(): iterable
{
yield 'Chrome' => [PantherTestCase::CHROME];
yield 'Firefox' => [PantherTestCase::FIREFOX];
Expand Down