Ctype: Give the correct deprecations for PHP 8.1+ #504
+34
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackEndTea
changed the title
derrabus
reviewed
Sep 26, 2024
stof
reviewed
Sep 26, 2024
src/Ctype/composer.json
Outdated
| @@ -16,7 +16,8 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": ">=7.2" | |||
| "php": ">=7.2", | |||
| "symfony/polyfill-php80": "^1.31" | |||
There was a problem hiding this comment.
why are you adding this dependency ?
There was a problem hiding this comment.
This is due to the usage of get_debug_type, since that was only added in PHP 8.0
I could switch it out with a gettype call if we are willing to accept a slight mismatch in error messages.
There was a problem hiding this comment.
wait: get_debug_type is behind a PHP_VERSION_ID >= 80100 check so the polyfill is never needed
There was a problem hiding this comment.
Youre correct, i didnt realize that!
BackEndTea
force-pushed
the
chore-correct-deprecation
branch
from
116cfd7 to
a56b42d
Compare
This isn't just for integers that are outside the integer range of -128, 255. https://3v4l.org/PgZ6c
BackEndTea
force-pushed
the
chore-correct-deprecation
branch
from
a56b42d to
7effac3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecation isn't just for integers that are outside the integer range of -128, 255.
https://3v4l.org/PgZ6c