Merged
Conversation
Closed
Fan2Shrek
reviewed
Mar 24, 2025
d91c7df to
0b4bd65
Compare
Fan2Shrek
approved these changes
Apr 1, 2025
nicolas-grekas
approved these changes
Jun 24, 2025
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
I changed the implementation this way:
- the validation of the arguments is already done by the call to bcdiv so there's not need to do it (and possibility introduce subtle behavioral diffs)
- the $scale of bcdiv should be
0explicitly IIUC
public static function bcdivmod(string $num1, string $num2, ?int $scale = null): ?array
{
- if (PHP_FLOAT_EPSILON < abs((float) $num2)) {
- throw new \DivisionByZeroError('Division by zero');
- }
-
- if (!is_numeric($num1)) {
- if (class_exists(\ValueError::class)) {
- throw new \ValueError('Argument #1 ($num1) is not well-formed');
- }
-
- trigger_error('Argument #1 ($num1) is not well-formed', E_USER_WARNING);
-
- return null;
- }
-
- if (!is_numeric($num2)) {
- if (class_exists(\ValueError::class)) {
- throw new \ValueError('Argument #2 ($num2) is not well-formed');
- }
-
- trigger_error('Argument #2 ($num2) is not well-formed', E_USER_WARNING);
-
- return null;
- }
-
- return [
- \bcdiv($num1, $num2),
- \bcmod($num1, $num2, $scale ?? \bcscale() ?? ini_get('bcmath.scale') ?: 0),
- ];
+ if (null === $quot = \bcdiv($num1, $num2, 0)) {
+ return null;
+ }
+ $scale = $scale ?? (\PHP_VERSION_ID >= 70300 ? \bcscale() : (ini_get('bcmath.scale') ?: 0);
+
+ return [$quot, \bcmod($num1, $num2, $scale)];
}
Member
|
Thank you @alexandre-daubois. |
Member
|
And thank you @Ayesh ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #503. Thank you @Ayesh!