PHP 8.5 - add PHP_BUILD_DATE constant
#545
Closed
+101
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Sep 7, 2025
Spomky
reviewed
Sep 7, 2025
| phpinfo(INFO_GENERAL); | ||
| $info = ob_get_clean(); | ||
|
|
||
| preg_match('@Build Date(?:( => | </td><td class="v">))(?<buildtime>[A-Za-z]{3} (?: \d|\d\d) \d{4} \d{2}:\d{2}:\d{2})@', $info, $matches); |
keradus
reviewed
Sep 7, 2025
| $this->assertEquals(new \stdClass(), array_last([true, new \stdClass()])); | ||
| } | ||
|
|
||
| public function testPhpBuildDate() |
There was a problem hiding this comment.
based on docs of phpinfo , would be good to run (or mock the run) under:
- cli
- webserver
- webserver with expose_php configuration setting is set to off
OskarStark
changed the title
PHP_BUILD_DATE constant
|
I'm going to save us all some time: this cannot be polyfilled efficiently. The polyfill relies on running some non-trivial code for everysingle requests, to populate a const that's going to be needed very few times. That's not worth the perf (and CO2) impact ! Thanks for your understanding. |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a polyfill for the
PHP_BUILD_DATEconstant (added in PHP 8.5).PHP_BUILD_DATEif not already defined, usingPhp85::php_build_date()php_build_date()helper to extract the build timestamp fromphpinfo()PHPUnittest to ensure the helper returns a valid and parseable build date string