Skip to content

feature [8.4][bcmath] implement bcround, bcceil and bcfloor #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

feature [8.4][bcmath] implement bcround, bcceil and bcfloor #546

wants to merge 1 commit into from

Conversation

Dean151
Copy link

@Dean151 Dean151 commented Sep 19, 2025 •
edited
Loading

  • introduced bcround, bcfloor and bcceil polyfills
  • RoundingMode cannot be an enum, and const cannot contain an object. This is the best pick I got to simulate an enum for PHP < 8.1
  • Tests are based on PHP bcmath extension official tests: https://github.com/php/php-src/tree/master/ext/bcmath/tests

stof
stof reviewed Sep 20, 2025
View reviewed changes
@Dean151 Dean151 force-pushed the feat/bcceil-bcfloor-bcround branch 4 times, most recently from 97257b6 to 394b10a Compare September 21, 2025 21:14
@Dean151 Dean151 force-pushed the feat/bcceil-bcfloor-bcround branch from 394b10a to dd5eded Compare September 21, 2025 21:30
@Dean151 Dean151 requested a review from stof September 25, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dean151 @stof