Skip to content

remove invalid redirection entry #21237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 23, 2025

(hopefully) fixes #21236

@javiereguiluz
Copy link
Member

I can't find the details, but I'm sure we did this on purpose to fix some issue.

For example, if you visit https://symfony.com/doc/6.4/components/string.html today, you see this in the version selector:

version-selector-6-4

And when you visit the version of the page after the redirect: https://symfony.com/doc/current/string.html you see this in the version selector:

version-selector-7-3

My guess is that this is a bug in symfony.com. The code that detects all the moved contents struggles a bit with situations like this.


I'd say today's situation is better and we should not merge this because:

  • If you visit the old version of the String docs, you see all the newer versions links
  • If you visit the new version of the String docs, you miss the legacy versions like 6.4 and older, but that should be OK for most readers

@OskarStark
Copy link
Contributor

But 6.4 is not legacy but LTS

@clement-michelet
Copy link
Contributor

I'd say today's situation is better and we should not merge this because:

  • If you visit the old version of the String docs, you see all the newer versions links
  • If you visit the new version of the String docs, you miss the legacy versions like 6.4 and older, but that should be OK for most readers

First, 6.4 is the current LTS so, no, it's not a legacy version.
Second, I cannot visit the old version by using the website because I'm redirected to the newer documentation which does not allow to select 6.4. I have to use a workaround : copy/past the old link from the search, change the version in url 🤦

I just want to be able to simply go to the older but maintained version documentation, I don't care how (duplicate result, selector with redirect, whatever). Telling readers to read 7.x version and do the burden to check if it's applicable to 6.x is not a suitable solution.

@javiereguiluz
Copy link
Member

Let's merge this and see how it goes! When upmerging, I'll revert this change in 7.2 and up.

Thanks Christian.

@javiereguiluz javiereguiluz merged commit 45ad3bf into symfony:6.4 Jul 28, 2025
3 checks passed
@xabbuh xabbuh deleted the issue-21236 branch July 28, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants