Skip to content

[CI] Rework app-tests job to use npm as user's packages manager #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

Kocal
Copy link
Member

@Kocal Kocal commented Jul 28, 2025

Q A
Bug fix? no
New feature? no
Docs? no
Issues Fix #...
License MIT

Following #2952, this way we ensure our packages will always be installable with npm (related to #2951)

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Jul 28, 2025
@Kocal Kocal force-pushed the ci-test-apps-npm branch 24 times, most recently from e3de2d0 to c9e4289 Compare July 28, 2025 22:50
@Kocal Kocal requested review from kbond and smnandre July 28, 2025 22:51
@Kocal Kocal added the DX label Jul 28, 2025
@Kocal Kocal force-pushed the ci-test-apps-npm branch 2 times, most recently from a947e12 to c4ee781 Compare July 28, 2025 23:03
@Kocal Kocal force-pushed the ci-test-apps-npm branch from c4ee781 to a90275b Compare July 28, 2025 23:05
@Kocal
Copy link
Member Author

Kocal commented Jul 28, 2025

Post Run actions/setup-node@v4
Post job cleanup.
Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

Maybe because I removed test_apps/encore-app/pnpm-lock.yaml?

W/e, CI is running fine now, workspace:* are now nicely replaced and npm is used as main packages manager to install dependencies inside app tests

EDIT: re-run the job in debug mode, it tried to cache path /home/runner/.local/share/pnpm/store/v10 but it does not since we do not run pnpm install anymore. I simply removed the cache step, it is not necessary

@Kocal Kocal force-pushed the ci-test-apps-npm branch from a90275b to a9ea07d Compare July 29, 2025 06:50
@Kocal Kocal merged commit b4c510d into symfony:2.x Jul 29, 2025
22 of 25 checks passed
@Kocal Kocal deleted the ci-test-apps-npm branch August 9, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants