Update readme with more information regarding v2 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
reviewed
Jan 8, 2026
| ``` | ||
|
|
||
| <br> | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Re-added them, I thought they were leftover HTML tags in a markdown file
TomasVotruba
reviewed
Jan 8, 2026
| ```bash | ||
| # generate patches | ||
| vendor/bin/vendor-patches generate | ||
| # (if using cweagans/composer-patches v2) |
Member
There was a problem hiding this comment.
I'm thinking, what is the added value of v2 here? It seems more and more work.
Instead, we should handle this for a user. Any chance we can include this complexity into our generate command to keep it working as before?
Contributor
Author
There was a problem hiding this comment.
I updated the README instructions because without executing the 2 additional commands, nothing happens to files in vendor/. This might lead to people just installing and assuming that files in vendor/ are patched.
I can add another PR that checks if v2 is installed and triggers the relock and repatch commands after generating the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.