-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: custom numberpad #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ovitrif
wants to merge
11
commits into
master
Choose a base branch
from
fix/custom-numpad
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8209f6d
to
28a4aea
Compare
app/src/main/java/to/bitkit/ui/screens/wallets/receive/ReceiveAmountScreen.kt
Fixed
Show fixed
Hide fixed
28a4aea
to
83b533b
Compare
83b533b
to
5bfc25a
Compare
5bfc25a
to
3bec3ff
Compare
# Conflicts: # app/src/main/java/to/bitkit/ui/screens/wallets/send/SendAmountScreen.kt # app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #309
Closes: #310
This PR refactors the custom numeric keyboard and its associated view amount display.
Description
Keyboard
component with newNumberPad
written from scratchNext steps:
AmountInput
usages with the newNumberPad
(ie. replace OS keyboard with custom one)NumberPadSimple
used to for pin input withNumberPad(type = NumberPadType.SIMPLE)
Preview
modernSend.mp4
classicTransfer.mp4
QA Notes
AmountInputViewModelTest
Tests
0.00
✓0.
, tap delete twice → entire input value deleted ✓.
→ input value =0.
✓0.
, tap delete twice → expect entire value deleted.
→ expect0.
as valueregression
: numpad in each flow:SendAmountScreen
: send > amountReceiveAmountScreen
: on wallet wo. LN >receive > tap receive on LN switchEditInvoiceScreen
: receive > editSpendingAmountScreen
: transfer to spendingregression
: edit invoice:regression
: pin input::