Date range selector sheet #181
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the existing date range selector with a new sheet-based implementation featuring an improved calendar interface. The update changes from a basic form-based date picker to a more interactive graphical calendar that allows users to select date ranges by tapping dates directly.
- Replaces the old
DateRangeSelectorcomponent with a newDateRangeSelectorSheet - Implements interactive calendar-based date range selection with visual feedback
- Updates the filter integration to use the new sheet component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DateRangeSelectorSheet.swift | New implementation with graphical calendar picker and range selection logic |
| DateRangeSelector.swift | Complete removal of the old form-based date selector |
| ActivityListFilter.swift | Updates sheet presentation to use the new DateRangeSelectorSheet component |
There was a problem hiding this comment.
Looks pretty good, just some minor issues, especially the first will be needed to make tests pass here
- should be able to filter by a single day (and clear it)
- when selecting a filter from a past month and reopening the sheet, it should show the month with the selected range
- there is a layout jump when making a selection
- use
SheetHeader, remove button bottom padding (already inSheet)
|
I pushed a couple of fixes, including:
|
| } else if isStartDate { | ||
| Circle() | ||
| .fill(Color.brand16) | ||
| UnevenRoundedRectangle( |
There was a problem hiding this comment.
nice! couldn't find this even with Claude help
There was a problem hiding this comment.
It is not perfectly aligned, but it is ok for now
Thanks! worked for me too Simulator.Screen.Recording.-.iPhone.16.-.2025-10-10.at.11.50.01.mp4 |
|
had to do one more push so I could be the last pusher again |
Description
This PR implements the date range selector sheet in the Activities screen
Linked Issues/Tasks
FIGMA
Roadmap item
Screenshot / Video
Tried to keep as close as possible from Figma
Simulator.Screen.Recording.-.iPhone.16.-.2025-10-10.at.10.20.45.mp4