Update mini-gdbstub with the API changes #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Mar 26, 2025
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: 874ad5c | Previous: 9c8f2ad | Ratio |
|---|---|---|---|
Dhrystone |
1287 Average DMIPS over 10 runs |
1317 Average DMIPS over 10 runs |
1.02 |
Coremark |
910.358 Average iterations/sec over 10 runs |
920.715 Average iterations/sec over 10 runs |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
RinHizakura
force-pushed
the
mini-gdbstub-update
branch
from
9c8f2ad to
874ad5c
Compare
|
Thank @RinHizakura for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support register >64bits(e.g. AVX register on x86), the corresponding interface changes are made on mini-gdbstub. Synchronize the library and interface to the latest version to facilitate future development. This may also be helpful if we had Vector Extensions in the future.
Summary by Bito
This pull request enhances the mini-gdbstub's register handling to support registers larger than 64 bits, including AVX registers on x86 architectures. It modifies relevant function signatures and implementations, and synchronizes the subproject commit with the latest library version for improved future development.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2