Skip to content

Support Linux 6.14 by about get_tx_power #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support Linux 6.14 by about get_tx_power #78

wants to merge 1 commit into from

Conversation

horseface1110
Copy link
Contributor

Linux kernel 6.14 introduced an additional link_id parameter to the get_tx_power callback. This commit updates vwifi_get_tx_power to match the new prototype while preserving compatibility with earlier kernels.

ref:
torvalds/linux@7a53af8

@horseface1110
Copy link
Contributor Author

After applying the above changes, the testing environment described in
the README under "Testing environment (virtio)" is now successfully running.

Sample output from ip link show:

1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
link/ether 52:54:00:12:34:56 brd ff:ff:ff:ff:ff:ff
3: vw0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
link/ether 00:76:77:30:00:00 brd ff:ff:ff:ff:ff:ff
4: vw1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast qlen 1000
link/ether 00:76:77:31:00:00 brd ff:ff:ff:ff:ff:ff

@jserv jserv requested a review from jychen0611 May 30, 2025 17:39
jychen0611
jychen0611 suggested changes May 31, 2025
View reviewed changes
Copy link
Collaborator

@jychen0611 jychen0611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following sentence to the commit message:

Since the current virtual interface does not support Multi-Link Operation (MLO),
there is no need to update the "get_tx_power" logic to handle per-link TX power.

@horseface1110 horseface1110 force-pushed the fix/get-tx-power-api-linux-6.14 branch from 3c5bc25 to 2a87f71 Compare June 2, 2025 08:27
@horseface1110
Copy link
Contributor Author

MLO clarification added to the commit message as suggested. Thanks!

jserv
jserv requested changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase the latest main branch.

@horseface1110 horseface1110 force-pushed the fix/get-tx-power-api-linux-6.14 branch from 2a87f71 to 2e9546f Compare June 5, 2025 02:55
@horseface1110
Copy link
Contributor Author

Rebased with the latest main.
Please let me know if anything else is needed. 🙌

@jserv
Copy link
Contributor

jserv commented Jun 5, 2025

Rebased with the latest main. Please let me know if anything else is needed. 🙌

You don't have to say words like "Please let me know if anything else is needed" since reviewers are notified by GitHub every time git activities trigger events. Concentrate on your work.

jserv
jserv requested changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow the citation style of commit 800ad32 for lean and informative messages.

@horseface1110
Support Linux v6.14
f82e7df 
Update vwifi_get_tx_power to match the new callback signature introduced
in Linux commit 7a53af85 ("wifi: cfg80211: send MLO links tx power info
in GET_INTERFACE"), which adds a link_id parameter to support reporting
TX power on a per-link basis under Multi-Link Operation (MLO).

Since vwifi does not support MLO, the implementation remains unchanged
aside from updating the function prototype. Compatibility with older
kernels is preserved using version checks.
@horseface1110 horseface1110 force-pushed the fix/get-tx-power-api-linux-6.14 branch from 2e9546f to f82e7df Compare June 5, 2025 16:56
@jserv jserv requested a review from jychen0611 June 6, 2025 15:43
jserv
jserv requested changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subject of git commit message was misleading. Improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jserv jserv jserv requested changes

@jychen0611 jychen0611 jychen0611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@horseface1110 @jserv @jychen0611