Skip to content

Conversation

btkostner
Copy link
Contributor

@btkostner btkostner commented Aug 5, 2025

This updates the GitHub actions to the latest version, uses cache everywhere (since it was already used a couple of places), and updates the deploy step to use actions instead of deploying via a git branch. This should improve clone performance a bit by not having an orphan with all of the images stored in git.

This will require you to change the github pages settings to deploy via "Github Actions" instead of "Deploy from a branch", and set the cname to support.system76.com.

https://github.com/system76/docs/settings/pages

@@ -0,0 +1 @@
nodejs 16.16.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supports things like mise, asdf, and the setup-node action. This is the latest supported version of node that works (all of the dependencies are pretty out of date)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We appeared to be using Node.js 18 in our local testing setup (a Nix shell) until today, and are now using Node.js 20. I see that the GitHub workflow used to use 14 and will now use 16. I'm not concerned about the version mismatch causing a problem since it already wasn't matching before, but I am confused if I'm comparing the right numbers or not. (Or maybe some dependencies that don't work with >16 versions aren't necessary for local builds but are for live deployment?)

node-version-file: .tool-versions

- id: cache
name: Cache
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well use it everywhere since we already are using it below.

@jacobgkau jacobgkau requested a review from a team August 7, 2025 20:34
@jacobgkau jacobgkau force-pushed the actions-upgrade branch 2 times, most recently from 093fac0 to 08f629a Compare September 3, 2025 20:38
@jacobgkau jacobgkau requested a review from a team September 3, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants