calocation: fix ESTALE when extracting to regular file #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Maintainer(s),
I met the issue discribed below when I want to extract an archive in an existing regular file. Note that it works well if the file is a block device.
I do not think this is the appropriate fix. It is much like a workaround. I need your help to fix it properly.
I would like to know why it is interresting to make such a test on the modification time of the file.
Regards,
Gaël
There is an issue when an archive is extracted to a regular file that
exists already.
The error raised is a difference in the modify time.
In the case of the destination regular file exists (ie. the second call
in the example above), the path goes to several fallocate/write calls
that causes the modification time to be updated and leads to that error.
This commit drops the check for the modification time.