Fix race condition / edge case in _strokeUpdate where this._data can sometimes be [] #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sometimes be [] Replicates https://github.com/szimek/signature_pad/pull/481/files but into v2 branch
|
I think there are better ways to handle agilgur5/react-signature-canvas#68 than to try to maintain old versions of signature_pad. see agilgur5/react-signature-canvas#68 (comment) |
|
I'd agree if there were a range; however this is just one change, and is for what seems to be quite a long standing issue. The benefit of this change is that it requires no changes downstream, and we already know this change fixes the issue in v4, so it should work here. So I guess it depends who has the responsibility, but the change here is definitely the lowest overall amount of work having to be done by people on aggregate. |
|
I don't think we are going to maintain two versions of this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicates #481 but into v2 branch.
There are other libraries that depend upon older versions of this library and may not want to carry out refactoring to upgrade through 2 major versions to receive this fix.
An example is discussed here agilgur5/react-signature-canvas#68
As the fix is very simple, and maps exactly from v4 back to v2, I am proposing this is merged and a new minor or point release of v2 is cut to include it.