fix(cli): guard importAlias type before string operations - #2238
Draft
okxint wants to merge 1 commit into
Draft
Conversation
…rror When --import-alias is passed without a value in CI mode, Commander sets the option to true (boolean) instead of a string. The subsequent .replace() calls on a non-string value crash with TypeError. Add typeof guards in both index.ts and setImportAlias.ts to handle this safely. Fixes t3-oss#2215
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a
TypeErrorcrash when--import-aliasis passed without a value in CI mode (--CI).Root cause
--import-aliasis declared as[alias](optional value) in Commander. When passed bare with--CI, Commander coerces it to the booleantrueinstead of a string. The CI path skips the interactive prompt, soimportAliasstays astrue. Downstream:index.tscomparesimportAlias !== "~/"—true !== "~/"passes, so the invalid value flows throughsetImportAlias.tscalls.replace()on it →TypeError: Cannot read properties of undefinedFix
Two defensive guards:
Fixes #2215