Query available devices from Win32_PnPEntity in FirmwareInstaller #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XScorpion2
requested changes
May 3, 2022
Collaborator
XScorpion2
left a comment
XScorpion2
left a comment
There was a problem hiding this comment.
Needs a small change
|
|
||
| public int CompareTo(COMDevice other) | ||
| { | ||
| int currentNumber = Int32.Parse(Port.Substring(Port.Length - 1)); |
Collaborator
There was a problem hiding this comment.
Com port range is 1-256 which is higher than a single digit so this will not work long term.
https://knowledge.ni.com/KnowledgeArticleDetails?id=kA00Z000000PAhzSAG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description
Currently, the available devices in FirmwareInstaller are listed by their port name (COM1, COM2..). With those changes, the devices will have the same name as in the device manager (ex: USB-SERIAL CH340 (COM3)).
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Device are now acquired with a query on
Win32_PnPEntityinstead of a call toSystem.IO.Ports.SerialPort.GetPortNames().