feat: make refresh consistent between endpoints #1665
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workbooks.refresh correctly accepted both an id string and a WorkbookItem to handle triggering refreshes. Datasources.refresh technically accepted both, but the type annotations did not reflect that. Flows.refresh only accepted a FlowItem, but will now accept a flow_id. This eliminates the need to create otherwise hollow FlowItems to pass to the refresh method when you otherwise have the id.
jorwoods
force-pushed
the
jorwoods/refresh_interface
branch
from
085456e to
43358da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workbooks.refresh correctly accepted both an id string and a
WorkbookItem to handle triggering refreshes. Datasources.refresh
technically accepted both, but the type annotations did not reflect
that. Flows.refresh only accepted a FlowItem, but will now accept
a flow_id. This eliminates the need to create otherwise hollow
FlowItems to pass to the refresh method when you otherwise have
the id.