Add Tableau OAuth support #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyoung-tableau
commented
Aug 8, 2025
src/config.ts
Outdated
| } | ||
|
|
||
| if (this.auth !== 'oauth') { | ||
| invariant(this.siteName, 'The environment variable SITE_NAME is not set'); |
There was a problem hiding this comment.
This is wrong. siteName can be empty for the default site on Server.
* Add back CA support
* Rename var
* s/replace/replaceAll
* Update readme
* Add tests
* Use jose instead of jsonwebtoken
* Update env examples
* Rename to JWT_ADDITIONAL_PAYLOAD
* Choose scopes per tool
* Fix tests
* Fix typo in readme
* Remove {OAUTH_USERNAME} when OAuth is not enabled
* Remove accessToken from AuthConfig
* Delete merge files
* Default additional payload to empty object
* Sign out for direct-trust too
* Add basePath to protected resource
* Use issuer instead
* Fix bad merge
* Again
* Add basic session management * Read originHost from token response * Remove state * Clean up * Combine env var docs * Change default access token timeout to 1 hour * Revert registerRequestHandlers * Add constant for TabCloud URL * Fix OAuth tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes introduce two new concepts:
To clarify, for MCP server admins who protect their server with Tableau OAuth, bullet 2 above is NOT a requirement. They can still provide a PAT or Connected Apps config to use for authenticating to the Tableau REST APIs.
In this implementation, the MCP server is functioning as the authorization server as well. This need not be the case though; the authorization server piece could be deployed as its own distinct service. If necessary, we can revisit the design based on customer feedback.
The OAuth 2.1 authorization flow is implemented as per the MCP spec version 2025-06-18:
This provider handles: