-
Notifications
You must be signed in to change notification settings - Fork 168
feat(stdlib): add jetton support #2509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat start! Currently editing the docs after which we'll be very close to merging this.
By the way, don't forget to add yourself and a new jetton-related entry to the CHANGELOG (I can do that too :)
doing just that UPD: 75% ready, cleaning up remaining parts |
ALL ABOARD, THE TIME HAS FINALLY COME TO REVIEW!!1! A couple of notes:
@Kaladin13 if you want to add any messages and/or rename some fields (minter → master), this is the time to do it. Otherwise, we can keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @novusnota!
A few comments:
@Kaladin13 @Shvandre @skywardboundd @i582 RFC, where C = Reviews |
It was a big review. We discussed docs changes with @novusnota internally, not to lose time on github review, as I really want it to be added in 1.6.6. Great job from @novusnota and @Kaladin13 . Thank you guys! P.S. Approve will be right here - right after changes :) |
Applying changes right now! 🐗 |
ping @skywardboundd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments have been resolved so here is the approval
🚀🚀🚀
@Kaladin13 @Shvandre @skywardboundd Sorry for tagging you guys once again, but if there are any things you'd like to fix regarding to benchmarked gas usage or contract sizes, then please do. The burn got more expensive because the upstream type of |
Awaits #2734 and some better Address type... UPD: And we might also set the Mint opcode to |
Issue
Closes #1562