Skip to content

feat(docs): clarify rounding, division operations and update descriptions #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(docs): clarify rounding, division operations and update descriptions #3320

wants to merge 9 commits into from

Conversation

geooner
Copy link

@geooner geooner commented May 30, 2025

@geooner
feat(docs): clarify division operations and update descriptions for c…
1dc23d5 
…eiling and floor division in math documentation
@geooner geooner requested a review from a team as a code owner May 30, 2025 20:32
@geooner geooner mentioned this pull request May 30, 2025
Open
@geooner
Copy link
Author

geooner commented May 31, 2025

Hi @novusnota @Gusarich the ci test passed. I think this is good to go, but still please review it, thanks.

@geooner
Copy link
Author

geooner commented Jun 4, 2025

Hello, @pyAndr3w @novusnota its been a while, do you guys have any updates on this?

@novusnota
Copy link
Member

novusnota commented Jun 4, 2025 •
edited
Loading

Hello, novusnota its been a while, do you guys have any updates on this?

Hi and sorry — I've been working on other things, but I'll happily review your PR a bit later today-tomorrow :)

novusnota
novusnota requested changes Jun 5, 2025
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've left suggested changes to apply, and if or once you agree, we'll proceed to merge them

@geooner
Copy link
Author

geooner commented Jun 5, 2025

@novusnota have a look now, I've applied your suggestions. I think this is ready to be merged now.

@novusnota novusnota changed the title Feat(docs): Clarify rounding, division operations and update descriptions feat(docs): clarify rounding, division operations and update descriptions Jun 5, 2025
novusnota
novusnota approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@geooner
Copy link
Author

geooner commented Jun 18, 2025

@novusnota hi, sorry to ping you again, but this has been open for a while now, could you please merge this?

@geooner
Copy link
Author

geooner commented Jun 18, 2025

@novusnota the ci passed

@novusnota
Copy link
Member

@novusnota hi, sorry to ping you again, but this has been open for a while now, could you please merge this?

@geooner I myself cannot merge this, but I've pinged the folks who can. Let's wait a bit to see their response 🙏

@novusnota novusnota requested a review from anton-trunov June 19, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota approved these changes

@Gusarich Gusarich Awaiting requested review from Gusarich

@anton-trunov anton-trunov Awaiting requested review from anton-trunov

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct and clarify rounding mode descriptions in docs
2 participants
@geooner @novusnota