Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes #347

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Small fixes #347

merged 2 commits into from
Dec 9, 2024

Conversation

leekillough
Copy link
Collaborator

@leekillough leekillough commented Dec 8, 2024 •
edited
Loading

  • fix a spacing issue in one of the error messages introduced by the last PR
  • change DECODE_* functions to return auto and to call BitExtract()
  • change CRegIdx() from a macro to a constexpr function
  • Remove redundant parentheses and use BitExtract() in the instruction decoder functions

kpgriesser
kpgriesser approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@kpgriesser kpgriesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good by me

@leekillough leekillough merged commit 8bf6deb into devel Dec 9, 2024
@leekillough leekillough deleted the Small_fixes branch December 9, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpgriesser kpgriesser kpgriesser approved these changes

@rkabrick rkabrick Awaiting requested review from rkabrick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leekillough @kpgriesser