Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use basic auth #9

Open
wants to merge 9 commits into
base: gh-pages
Choose a base branch
from

Conversation

robertlabrie
Copy link

Because reasons, we have to access InfluxDB through nginx as a rev proxy with basic auth and not at the root, so this introduces two big changes:

  1. A thing called baseUrl which if specified is used in place of the connection options: a new method getInfluxUrl() spits out the final bits you need
  2. A checkbox to use Basic Auth instead of Influx Auth

@tagyoureit
Copy link
Owner

Thanks @robertlabrie. Let me go through this code this week.

@tagyoureit
Copy link
Owner

Hi @robertlabrie. Thanks for submitting this PR. It looks like you've put quite a bit of work into understanding and modifying the code so kudos for that. I think I understand what you are trying to do at a high level, but the UI might be confusing me a bit.

Are there two separate logins for Nginx and then Influx? What does your "final" url look like to let you pass through the proxy to Influx?

Where you have "Enter a base url to use for Influx requests - this overrides the server settings above" this will completely replace the protocol, server and port settings?

On the Auth screen - the user selects "Use Auth" but then you added a checkbox for "Use basic auth". What exactly does this checkbox do?

Does it make more sense to have three/four different connection views?

  1. Normal/basic = protocol, server port
  2. Influx Auth = 1 above plus username password
  3. Nginx Auth = new options with just the "Enter a base url..."
    and/or
  4. Is there a combination of Nginx & Influx Auth?

thanks,
tag

@robertlabrie
Copy link
Author

robertlabrie commented Aug 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants