Change the COMMENTS.OLDER_FIRST and RECENT_FIRST to make it clear it is an action#234
Open
mig5 wants to merge 1 commit intotaigaio:mainfrom
Open
Change the COMMENTS.OLDER_FIRST and RECENT_FIRST to make it clear it is an action#234mig5 wants to merge 1 commit intotaigaio:mainfrom
mig5 wants to merge 1 commit intotaigaio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen multiple users express confusion that, in the Comments section of an item, 'Older first' and 'Recent first' seem reversed to most people's instinctive understanding.
When they see 'Older first', they think 'the comments are being shown as Oldest first', when in fact the reverse is true.
The reason is that the button text is really representing a proposed 'action', not representative of its current state. Much like how a form button 'Submit' or 'Save' does not mean 'It is submitted' or 'It is saved', but that clicking the button will make it so.
I think the cause for the confusion is that the 'Older first' / 'Recent first' do not look like normal buttons - they look like sort-order toggles.
In this PR I have changed it to have the 'Click to view' prefix, which makes it clearer to English speakers that taking an action (clicking on it) will result in that change.