android/src/main: show exit node information in the permanent notification #642
+840
−859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Meysner <[email protected]>
Pull Request Revisions
HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
![review-ai-agent[bot]](https://avatars.githubusercontent.com/in/1104228?s=60&v=4){kind=small}
…ation Displays exit node status (including the name of the exit node) in the permanent connection notification's content (moving the overall connected/disconnected status to the title). Fixes tailscale/tailscale#14438 Signed-off-by: Jakub Meysner <[email protected]>
…h for files destination directory > If the source is a file, and the destination doesn't end with a trailing slash, the source file will be written to the destination path as a file. ~ https://docs.docker.com/reference/dockerfile/#destination Signed-off-by: Jakub Meysner <[email protected]>
jakubmeysner
force-pushed
the
feature/#14438-display-exit-node-information-in-permanent-notification
branch
from
f642bde to
af44e1e
Compare
|
Hi @kari-ts and @nickoneill, sorry about the mention(s), but could you please take a look at this PR when you have a chance? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays exit node status (including the name of the exit node) in the permanent connection notification's content (moving the overall connected/disconnected status to the title).
Fixes tailscale/tailscale#14438
Could potentially also be extended to modify the notification icon similarly to desktop - however I do not have access to that asset, and it'd probably require some modification to fit within the safe display area.
Also includes formatting of existing code using ktfmt (
ktfmtFormatGradle task) and a fix for an invalid instruction in the Dockerfile causing build failures.